tech-toolchain archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: 10.1 make oddity



>> make: Unclosed substitution for  (; missing)
>> make: Unclosed substitution for  (; missing)
>> make: "/home/mouse/z.local/lib/make/local-prog" line 115: Need an operator

>> Here's a cut-down test case: [...]

> Then, in December of 2008, the handling of .for loops changed, and
> since then, your test failed:

While it admittedly is armchair quarterbacking, I would submit that it
is a process failure if the test started failing and neither the code
nor the test and documentation got fixed.  In this case, obviously, I
would have argued for fixing the code. :-)

> [...explanation...]

Yes, that does explain.

> I consider the ad-hoc semicolon finder a bug.

So do I!

> I have a patch ready that fixes the code to use the existing
> expression parser.  With this fix, your test results in this
> dependency:

>> /tmp/cat1/a.0:		 /tmp/cat1	 a.cat1

> That looks good to me.

Agreed.

Is this in the queue for committing, or would it help for me to
generate a PR for it, or...?

/~\ The ASCII				  Mouse
\ / Ribbon Campaign
 X  Against HTML		mouse%rodents-montreal.org@localhost
/ \ Email!	     7D C8 61 52 5D E7 2D 39  4E F1 31 3E E8 B3 27 4B


Home | Main Index | Thread Index | Old Index