tech-toolchain archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: make: warn about fallback from parallel to compat mode



Am 23.05.2025 um 15:25 schrieb Christoph Badura:
> I haven't seen a commit message that indicates you committed this, so I
> guess it's still fine to comment.
> 
> On Mon, May 12, 2025 at 08:50:26PM +0200, Roland Illig wrote:
>>
>> The attached patch warns about cases like this. The warning is quite
>> verbose, but I didn't manage to make it shorter without sacrificing
>> understandability.
> 
> The warning seems fine to me.  It's not supposed to appear often, isn't it?

It is _supposed_ to appear never, but currently it does appear in
several places. I'm fixing them one by one.

Even though the diagnostic is detailed, I found out that without a stack
trace across multiple make and sub-make processes, it's hard to find out
what to fix and where. I have a change for that in my local tree and
will commit it after testing it in practice.

>> +	If the target is supposed to recurse even with -n, add the .MAKE pseudo-source to the target.
>> +	Otherwise, add a ${:D make} marker to a command from the target.
> 
> "to a command *for* the target" is the correct wording, I think.

In the end, I had to reword that sentence, as the ${:D make} marker has
to be added to the exact command that runs the sub-make, not any other
command from the same target.

Roland



Home | Main Index | Thread Index | Old Index