Re: CVS commit: src/usr.bin/crunch/crunchgen

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Mon, Dec 23, 2019 at 06:54:47PM -0000, Christos Zoulas wrote:
> Here is a patch that:
> 
> 1. removes all the special handling of variables (-d -p -P -s -S) that
>    were dealing with DBG (-d) LDSTATIC/NOPIE (-p), and the rest with
>    disabling/enabling sanitizers.
> 2. uses emalloc/estrdup for all the allocators instead of only some cases.
> 3. adds -V varspec which passes variables on the command line (as DBG
>    and LDSTATIC used to be passed before) instead of appending them
>    to the on-the-fly Makefile using -v varspec.
> 
> The motivation of this is to make variable handling consistent, less magical,
> and remove the need for changing crunchgen each time we want to add disabling
> an option by default.

I like this in principle, but I haven't double checked everything.

Joerg