Re: -std=gnu99

[David Holland <dholland-tech%netbsd.org@localhost>]

On Tue, May 20, 2014 at 07:00:11PM +0100, Iain Hibbert wrote:
 > > On Fri, May 16, 2014 at 09:10:12PM +0100, Iain Hibbert wrote:
 > >> I mean to change bsd.sys.mk to always provide -std=gnu99 in CFLAGS as per
 > >> below patch, as if the code base requires gnu99 then it will require it
 > >> whichever compiler is in use.
 > >
 > > ...why break the build system so as to pass a gcc (and clang) option
 > > to potentially arbitrary other compilers that won't understand it?
 >
 > which other compilers?

Well, there's pcc, but I suppose if it didn't understand this option
ragge would have said so upthread.

However, what I meant was: any others we might want to try or tinker
with. All you're doing is increasing the amount of effort it takes to
try a different compiler. By all means fix the conditional to test the
right thing, and add pcc to it if appropriate. But there's no benefit
to *removing* the conditional.

 > > AIUI it should be conditionalized on ACTIVE_CC, but it should still be
 > > conditionalized.
 > 
 > Except for the fact that if it were to be conditional, then yes it should
 > be using ACTIVE_CC (which is a different WTF itself), I don't agree. The
 > sources are currently too dependent on GNU C, and you just can't build
 > NetBSD without GCC compat active.

That's a bug. Don't add to it / make it worse.

-- 
David A. Holland
dholland%netbsd.org@localhost