tech-toolchain archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: make: Check_Cwd_av handle -C or remove?



On Sat, Jan 19, 2013 at 06:54:29PM +0200, Alan Barrett wrote:
 > >I added the Check_Cwd_av logic at least 10 years ago, to avoid
 > >the need to fix lots of makefiles which didn't work with
 > >MAKEOBJDIRPREFIX.
 > 
 > If I understad correctly, that was a workaround for buggy Makefiles
 > that assumed that they could do
 > 
 >      sometarget:
 >              ${MAKE} othertarget
 > 
 > when they should really have done
 > 
 >      sometarget:
 >              (cd ${.CURDIR} && ${MAKE} othertarget)
 > 
 > >I suspect the need for it has passed.  Building with separate obj
 > >trees (via MAKEOBJDIRPREFIX etc), seems almost universal now.
 > >Perhaps it is time to retire this check or perhaps disable it by
 > >default?
 > 
 > I think that removing it would be fine.  I don't think that it was
 > ever a good idea.  In other words, I think that people who write
 > incorrect rules in their Makefiles should lose, not be pampered by
 > having make guess whether or not they meant to insert cd
 > ${.CURDIR}.

Yes, I agree; also, I see no reason to provide things that encourage
the use of make's objdirs misfeature.

-- 
David A. Holland
dholland%netbsd.org@localhost


Home | Main Index | Thread Index | Old Index