Re: make: .PHONY lacks .TARGET

[David Holland <dholland-tech%netbsd.org@localhost>]

On Tue, Sep 27, 2011 at 10:01:02AM -0700, Simon Gerraty wrote:
 > Index: suff.c
 > ===================================================================
 > RCS file: /cvsroot/src/usr.bin/make/suff.c,v
 > retrieving revision 1.68
 > diff -u -p -r1.68 suff.c
 > --- suff.c   30 Jun 2011 20:09:42 -0000      1.68
 > +++ suff.c   27 Sep 2011 17:00:21 -0000
 > @@ -2411,6 +2411,10 @@ SuffFindDeps(GNode *gn, Lst slst)
 >       * If dependencies already found, no need to do it again...
 >       * If this is a .PHONY target, we do not apply suffix rules.
 >       */
 > +    if (gn->type & OP_PHONY) {
 > +        /* But we do want to make sure this is set. */
 > +        Var_Set(TARGET, gn->path ? gn->path : gn->name, gn, 0);
 > +    }
 >      return;
 >      } else {
 >      gn->type |= OP_DEPS_FOUND;

Does this work with make -j? (I'm just remembering the history of PR
43534, which is related enough to make me slightly nervous.)

-- 
David A. Holland
dholland%netbsd.org@localhost