Subject: Re: Add libprop include path to libkern/Makefile.inc (was: CVS commit:src/sys/arch/arc/stand/boot)
To: None <tech-toolchain@NetBSD.org>
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
List: tech-toolchain
Date: 08/27/2006 22:21:17
Is it okay to commit the following patch for PR 33431,
to allow building standalone programs without DESTDIR?
(arch/sparc/stand/bootblk/Makefile also requires the similar fix)
<060726204808.M0117230@mirage.ceres.dti.ne.jp> on source-changes
I wrote:
> simonb@NetBSD.org wrote:
>
> > We previously had a (unwritten?) goal of being able to build
> > sys/arch/*/stand without ${DESTDIR}. Do we still want to be able to do
> > this? I still find it handy to be able to do this to test out fixes and
> > changes for bootblocks without having to run a partial build.sh first...
>
> IMHO, the required fix is trivial, so we should keep
> the (actually useful and reasonable) goal :-)
> (though I'm not sure which Makefile or Makefile.inc is better)
> ---
> Izumi Tsutsui
>
>
> Index: sys/lib/libkern/Makefile
> ===================================================================
> RCS file: /cvsroot/src/sys/lib/libkern/Makefile,v
> retrieving revision 1.80
> diff -u -r1.80 Makefile
> --- sys/lib/libkern/Makefile 27 Apr 2006 20:43:09 -0000 1.80
> +++ sys/lib/libkern/Makefile 26 Jul 2006 11:42:19 -0000
> @@ -28,6 +28,8 @@
> .include "${.PARSEDIR}/../../../common/lib/libc/Makefile.inc"
> .include "${.PARSEDIR}/../../../common/lib/libprop/Makefile.inc"
>
> +CPPFLAGS+= -I${KERNDIR}/../../../common/include
> +
> .PATH.c: ${KERNDIR}
> .if exists ($M/Makefile.inc)
> .PATH.c: $M
>