Subject: Re: build.sh snapshot doesn't run postinstall fix obsolete
To: None <tech-toolchain@netbsd.org>
From: Luke Mewburn <lukem@NetBSD.org>
List: tech-toolchain
Date: 06/28/2005 09:47:34
--Rg893I9M3tK9A1lH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jun 26, 2005 at 02:38:54PM +0100, David Laight wrote:
  | The 'distribution' target of src/Makefile contains:
  |=20
  | .if defined(DESTDIR) && ${DESTDIR} !=3D "" && ${DESTDIR} !=3D "/"
  | 	${MAKEDIRTARGET} . postinstall-fix-obsolete
  | 	${MAKEDIRTARGET} distrib/sets checkflist
  | .endif
  |=20
  | Which helpfully removes any old files before running checkflist.
  |=20
  | However there is nothing that runs the postinstall-fix-obsolete if
  | you execute the 'snapshot' target.
  | I can't see the best place to add it either, 'snapshot' doesn't seem
  | to be implemented the same way as distribution.  I would have thought
  | that it would do 'distribution' first.
  |=20
  | This is all a PITA because there isn't an easy way to perform the
  | latter stages of a 'snapshot' without trundling through many minutes
  | of pointless makefiles.

Maybe the "release snapshot" targets should be changed from
	${MAKEDIRTARGET} . build NOPOSTINSTALL=3D1
	${MAKEDIRTARGET} etc release INSTALL_DONE=3D1
to
	${MAKEDIRTARGET} . distribution
	${MAKEDIRTARGET} etc release DISTRIBUTION_DONE=3D1


Alternatively, add the postinstall-fix-obsolete target to the
"release snapshot" targets; something like:

	${MAKEDIRTARGET} . build NOPOSTINSTALL=3D1
=2Eif defined(DESTDIR) && ${DESTDIR} !=3D "" && ${DESTDIR} !=3D "/"
	${MAKEDIRTARGET} . postinstall-fix-obsolete
=2Eendf
	${MAKEDIRTARGET} etc release INSTALL_DONE=3D1

--Rg893I9M3tK9A1lH
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (NetBSD)

iD8DBQFCwJAWpBhtmn8zJHIRAn4MAKDKHn2Ug8gc3bDcLehL0j8E26hxRQCdH49Z
lW8l2GtwAvN8PQIZqFhGV2w=
=h2nD
-----END PGP SIGNATURE-----

--Rg893I9M3tK9A1lH--