On Nov 29,  5:34pm, jwise@draga.com (Jim Wise) wrote:
-- Subject: Re: Option to make cpp(1) not accept named pipes or devices as in

| -----BEGIN PGP SIGNED MESSAGE-----
| Hash: SHA1
| 
| On Mon, 29 Nov 2004, Christos Zoulas wrote:
| 
| >Can you do diff -u? Also "do not open non regular files" -> "only open regular files"
| 
| Done.  Updated patch at same URL:

thanks,

1. I would call "temp" "only_reg" or something more meaningful.
2. I'd kill the second space in 'if ( (temp'
3. I would clear non blocking mode after I was done with the IS_REG test:
     if (temp)
       (void)fcntl(file->fd, F_SETFL, fcntl(file->fd, F_GETFL, 0) & ~O_NONBLOCK);
4. I would prefer to have access to this via a command line flag.

christos