Subject: Re: CVS commit: src/usr.bin/make
To: matthew green <mrg@eterna.com.au>
From: Simon J. Gerraty <sjg@crufty.net>
List: tech-toolchain
Date: 07/01/2004 08:24:37
On Thu, 01 Jul 2004 17:12:19 +1000, matthew green writes:
>   
>   >Log Message:
>   >Add some checks for gcc around a few function declarations and note the
>   >unused variables. Also fix a few other warnings that PR#22118 shows when
>   >trying to compile bmake on non-NetBSD hosts
>   
>   This seems a rather ugly solution.  The FreeBSD cdefs.h has things like
>
>freebsd? :-)

Yes, I looked at NetBSD 1.6 which doesn't have the following.

>phat-bass ~> grep __unused /usr/include/sys/cdefs.h
>#define __unused        __attribute__((__unused__))
>#define __unused        /* delete */

The above is a much better solution that adding #ifdef's to a bunch of
function decls.

--sjg