Subject: Commit to src/lib/libc/stdio/fparseln.c breaks foreign crossbuilds
To: None <tech-toolchain@netbsd.org>
From: sgimips NetBSD list <sgimips@mrynet.com>
List: tech-toolchain
Date: 05/11/2004 04:52:04
The commit on 2004.5.10 against src/lib/libc/stdio/fparseln.c breaks crossbuilds
on (at least) FreeBSD and IRIX systems:

>>> Subject: CVS commit: src/lib/libc/stdio
>>> To: None <source-changes@NetBSD.org>
>>> From: Matthias Drochner <drochner@netbsd.org>
>>> List: source-changes
>>> Date: 05/10/2004 16:50:23
>>> 
>>> Module Name:    src
>>> Committed By:   drochner
>>> Date:           Mon May 10 16:50:23 UTC 2004
>>> 
>>> Modified Files:
>>>     src/lib/libc/stdio: fparseln.c
>>> 
>>> Log Message:
>>> Add FLOCKFILE() locking - should be threadsafe now.
>>> (Didn't test the !HAVE_FPARSELN && !_REENTRANT case -- this might be
>>> hit in tools/compat on some host platforms.)
>>> 
>>> 
>>> To generate a diff of this commit:
>>> cvs rdiff -r1.2 -r1.3 src/lib/libc/stdio/fparseln.c
>>> 
>>> Please note that diffs are not public domain; they are subject to the
>>> copyright notices on the relevant files.

I haven't tried crossbuilding from a netbsd host.

The resulting error during a "tools" build is:

#   compile  compat/fparseln.lo
cc -O  -I. -I./include -I/tiny/src/hp300-main/tools/compat -DHAVE_NBTOOL_CONFIG_H=1  -D_FILE_OFFSET_BITS=64 -D_NETBSD_SOURCE -D__DBINTERFACE_PRIVATE -c -o fparseln.lo.o    /tiny/src/hp300-main/lib/libc/stdio/fparseln.c
/tiny/src/hp300-main/lib/libc/stdio/fparseln.c:51:23: reentrant.h: No such file or directory

*** Failed target:  fparseln.lo
*** Failed command: cc -O -I. -I./include -I/tiny/src/hp300-main/tools/compat -DHAVE_NBTOOL_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 -D_NETBSD_SOURCE -D__DBINTERFACE_PRIVATE -c -o fparseln.lo.o /tiny/src/hp300-main/lib/libc/stdio/fparseln.c
*** Error code 1

Stop.
nbmake: stopped in /tiny/src/hp300-main/tools/compat

*** Failed target:  dependall

I've tried on sgimips, hp300, vax, sparc and sparc64 crossbuilds on FreeBSD 4.x and 5.x 
on both i386 and alpha hosts.

Is this perhaps a mod-in-progress that hasn't been fully committed yet?

-scott