Subject: Re: CVS commit: src/usr.bin/make
To: Jun-ichiro itojun Hagino <itojun@NetBSD.org>
From: Simon J. Gerraty <sjg@crufty.net>
List: tech-toolchain
Date: 07/15/2003 23:56:34
>Module Name:	src
>Committed By:	itojun
>Date:		Tue Jul 15 05:38:25 UTC 2003

>Modified Files:
>	src/usr.bin/make: job.c

>Log Message:
>vi

a/ could we have meaningful log messages
b/ could you please explain why it is necessary to strlcpy() in this
case?  You've just made it necessary to add strlcpy() to the next version
of bmake for little benefit - copying a fixed sized string into a known
sized buffer isn't the stuff of buffer overflows.

Or are you planning to replace all str*cpy calls in the tree with strlcpy?
I'm sure there are places that warrant it - even within make - but
this specific case doesn't appear to be one.

Thanks
--sjg