Subject: Re: identify packages that were custom built?
To: Jeremy C. Reed <reed@reedmedia.net>
From: Roland Illig <rillig@NetBSD.org>
List: tech-pkg
Date: 09/19/2007 19:26:06
Jeremy C. Reed wrote:
> p.s. Okay to commit the following (even though 
> APACHE_SUEXEC_CONFIGURE_ARGS includes APACHE_SUEXEC_DOCROOT)?
> 
> Index: www/apache/Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/www/apache/Makefile,v
> retrieving revision 1.191
> diff -u -r1.191 Makefile
> --- www/apache/Makefile	4 Jul 2007 20:55:02 -0000	1.191
> +++ www/apache/Makefile	19 Sep 2007 15:47:49 -0000
> @@ -80,6 +80,7 @@
>  			${APACHE_SUEXEC_CONFIGURE_ARGS:M--suexec-*}
>  PLIST_SRC=		${PKGDIR}/PLIST.suexec
>  BUILD_DEFS+=		APACHE_SUEXEC_CONFIGURE_ARGS
> +BUILD_DEFS+=	`	APACHE_SUEXEC_DOCROOT

Listing *_DOCROOT instead of *_CONFIGURE_ARGS is way better. I would 
leave out *_CONFIGURE_ARGS completely and add the variables that are 
mentioned in pkglint's warnings.

Roland