Subject: Re: python24-2.4.4 needs privileges to "make clean"
To: Christoph Badura <bad@bsd.de>
From: Adrian Portelli <adrianp@stindustries.net>
List: tech-pkg
Date: 06/24/2007 13:09:45
Christoph Badura wrote:
> On Sat, Jun 09, 2007 at 09:35:20PM +0100, Adrian Portelli wrote:
>> There are a few packages like this and Python has been like that for a
>> while (maybe not 2.4 but I definitely have seen it when building Python
>> myself in the past). There are also other packages that need to be the
>> superuser to build. I think it would be nice to fix this in some
>> 'global' way as I don't believe it is possible to fix all the packages
>> that do this on an individual basis.
>
> I like Amitai's proposal. It solves the problem for now and it serves
> as documentation marking the problematic packages.
>
> --chris
Then if no one has any objections I'll commit the attached patch when
the freeze is over. I've tested this with lang/python24 on NetBSD and
it works as expected. The package syntax will be as Amitai suggested:
PRIVILEGED_STAGE+= clean
adrian.
Index: mk/bsd.pkg.clean.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/bsd.pkg.clean.mk,v
retrieving revision 1.9
diff -u -r1.9 bsd.pkg.clean.mk
--- mk/bsd.pkg.clean.mk 9 Oct 2006 11:44:06 -0000 1.9
+++ mk/bsd.pkg.clean.mk 24 Jun 2007 12:07:42 -0000
@@ -27,6 +27,10 @@
CLEANDEPENDS?= no
+.if defined(PRIVILEGED_STAGE) && !empty(PRIVILEGED_STAGE:Mclean)
+_MAKE_CLEAN_AS_ROOT=yes
+.endif
+
.PHONY: clean-depends
clean-depends:
${_PKG_SILENT}${_PKG_DEBUG} \