Subject: Re: Ignoring patch files with missing checksums
To: Matthias Scheler <tron@zhadum.org.uk>
From: David Brownlee <abs@NetBSD.org>
List: tech-pkg
Date: 06/08/2007 16:32:20
On Fri, 8 Jun 2007, Matthias Scheler wrote:

> On Fri, Jun 08, 2007 at 11:41:30AM +0100, David Brownlee wrote:
>>> I would like to change "pkgsrc/mk/patch.mk" to return an error if it
>>> encounters an patch file that is not recorded in "distinfo" and
>>> "PKG_DEVELOPER" is set to "yes".
>>>
>>> That should avoid mistakes like this one:
>>>
>>> http://mail-index.netbsd.org/pkgsrc-changes/2007/06/08/0032.html
>>
>> 	I'd like another variable which can be set to skip the check,
>> 	so I can do 'make CHECK_PATCHES_DISTINFO=NO', but otherwise
>> 	*YES*
>
> In addition or instead of my suggested change?

 	I'd be happy if patch.mk defaulted to returning an error if
 	it encounters an patch file that is not recorded in "distinfo",
 	whether or not PKG_DEVELOPER was set. Its just important to
 	be able to override it on the command line, similar to being
 	able to set NO_CHECKSUM=yes.

-- 
 		David/absolute       -- www.NetBSD.org: No hype required --