Subject: MAKE_JOBS_SAFE change for mk/build.mk
To: None <tech-pkg@netbsd.org>
From: Blair Sadewitz <blair.sadewitz@gmail.com>
List: tech-pkg
Date: 12/15/2006 04:01:22
I'm just wondering something like this could be implemented:

Index: build.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/build/build.mk,v
retrieving revision 1.9
diff -u -r1.9 build.mk
--- build.mk    9 Nov 2006 02:53:15 -0000       1.9
+++ build.mk    15 Dec 2006 08:54:36 -0000
@@ -33,7 +33,7 @@

 .if defined(MAKE_JOBS_SAFE) && !empty(MAKE_JOBS_SAFE:M[nN][oO])
 _MAKE_JOBS=    # nothing
-.elif defined(MAKE_JOBS)
+.elif defined(MAKE_JOBS) && empty(MAKE_JOBS_SAFE_OVERRIDE:M${PKGBASE})
 _MAKE_JOBS=    -j${MAKE_JOBS}
 .endif

Given that I don't see MAKE_JOBS_SAFE=no appearing in the relevant
places, it would give people like me who use this feature a place to
record packages that fail with this instead of modifying many
Makefiles and maintaining the changes in-tree.  IMHO, it's much easier
to set MAKE_JOBS_SAFE_OVERRIDE (or maybe it should be called
DISABLE_MAKE_JOBS) than edit individual Makefiles.

Regards,

--Blair


-- 
Support WFMU-FM: free-form radio for the masses!

<http://www.wfmu.org/>
91.1 FM Jersey City, NJ
90.1 FM Mt. Hope, NY

"The Reggae Schoolroom":
<http://www.wfmu.org/playlists/RS/>