On 9/17/06, Joerg Sonnenberger <joerg@britannica.bec.de> wrote:
> On Sun, Sep 17, 2006 at 06:57:59PM +0200, Julio M. Merino Vidal wrote:
> > On 9/17/06, Joerg Sonnenberger <joerg@britannica.bec.de> wrote:
> > >On Sun, Sep 17, 2006 at 03:05:47AM +0200, Thomas Klausner wrote:
> > >> Latest fontconfig (2.4.0) seems to populate ${PREFIX}/var/fontconfig
> > >> sometimes, which breaks CHECK_FILES builds. Is it ok to add that
> > >> directory to CHECK_FILES_SKIP?
> > >
> > >I'd prefer the attached patch. Any objections?
> >
> > Would you please use a INSTALL script instead of @exec/@unexec lines?
>
> Updated patch is attached. It also creates the fc-cache at build time.

You can probably avoid these:

+MKDIR="@MKDIR@"
+PREFIX="@PREFIX@"
+VARBASE="@VARBASE@"

since USE_PKGINSTALL=YES has been a default for a long time and that
pulls in a header that defines variables for the most basic stuff.
(See scrollkeeper's INSTALL for an example.)

> What about checking if ${PREFIX}/bin/fc-cache exists in
> mk/pkginstall/fonts and call it if it is present?

That sounds like a good idea and a simple way to achieve it, but it is
not the cleanest.  I think it was you who proposed adding "triggers",
and this is where they could be useful.  But that is a long term
solution so your idea seems fine.

Also... what if fc-cache is also provided by the native X11?  Isn't
this the case in NetBSD?

-- 
Julio M. Merino Vidal <jmmv84@gmail.com>
The Julipedia - http://julipedia.blogspot.com/