In article <20060702181653.4CE27211CA@cvs.netbsd.org> Juan wrote:

: Module Name:    pkgsrc
: Committed By:   xtraeme
: Date:           Sun Jul  2 18:16:53 UTC 2006

: Modified Files:
:         pkgsrc/comms/openobex: Makefile distinfo
: Added Files:
:         pkgsrc/comms/openobex/patches: patch-aa patch-ab patch-ac patch-ad
:             patch-ae patch-af

: Log Message:
: Add support for NetBSD's bluetooth, required by the upcoming package
: obexapp.

: Bump PKGREVISION.

> $NetBSD: patch-af,v 1.1 2006/07/02 18:16:53 xtraeme Exp $
> 
> --- src/obex.h.orig     2006-07-02 19:31:28.000000000 +0200
> +++ src/obex.h  2006-07-02 19:31:36.000000000 +0200
> @@ -51,7 +51,7 @@
>  typedef void* obex_object_t;
>  typedef void (*obex_event_t)(obex_t *handle, obex_object_t *obj, int mode, int
> event, int obex_cmd, int obex_rsp);
>  // This is to workaround compilation without Bluetooth support. - Jean II
> -#ifndef SOL_RFCOMM
> +#ifdef SOL_RFCOMM
>  typedef char* bdaddr_t;
>  #endif

  This seems wrong.  What was your intention here?

  obex.h is an installed include file, and now it requires bdaddr_t to
be defined if Bluetooth support is *not* present.  It breaks building
packages using openobex on platforms without Bluetooth support
(e.g. NetBSD 3.0).  (It might also break platforms with Bluetooth
support, if btaddr_t is not char *.)

  Please fix it or back it out.

						yours,
						dillo