-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

"Jeremy C. Reed" <reed@reedmedia.net> writes:

> On Tue, 16 May 2006, Jeremy C. Reed wrote:
>
>> DIST_SUBDIR should not be PKGNAME. The pkgsrc Guide suggests using
>> PKGNAME_NOREV. (See " How to handle modified distfiles with the 'old' 
>> name".)
>
> I also want to mention that pkglint checks for this.

Is pkglint run regularly against pkgsrc?  It appears this got
commited with r1.31 about 10 days ago.

And should I submit a PR for the trivial patch to get ap-php
working again:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/lang/php5/Makefile,v
retrieving revision 1.33
diff -u -2 -r1.33 Makefile
- --- Makefile    16 May 2006 19:54:02 -0000      1.33
+++ Makefile    17 May 2006 04:49:54 -0000
@@ -33,5 +33,5 @@

 # This can be removed once 5.1.5 is released
- -DIST_SUBDIR=           ${PKGNAME}
+DIST_SUBDIR=           ${DISTNAME}

 post-install:
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/lang/php5/distinfo,v
retrieving revision 1.21
diff -u -2 -r1.21 distinfo
- --- distinfo    16 May 2006 19:54:02 -0000      1.21
+++ distinfo    17 May 2006 04:49:54 -0000
@@ -1,7 +1,7 @@
 $NetBSD: distinfo,v 1.21 2006/05/16 19:54:02 adrianp Exp $

- -SHA1 (php-5.1.4nb1/php-5.1.4.tar.bz2) = 83d4c5a4a3e8f3bcb0da841edd8d55893dbf5394
- -RMD160 (php-5.1.4nb1/php-5.1.4.tar.bz2) = d4ab11884a3a899f21eef777767a553cf81584ce
- -Size (php-5.1.4nb1/php-5.1.4.tar.bz2) = 6356171 bytes
+SHA1 (php-5.1.4/php-5.1.4.tar.bz2) = 83d4c5a4a3e8f3bcb0da841edd8d55893dbf5394
+RMD160 (php-5.1.4/php-5.1.4.tar.bz2) = d4ab11884a3a899f21eef777767a553cf81584ce
+Size (php-5.1.4/php-5.1.4.tar.bz2) = 6356171 bytes
 SHA1 (patch-ag) = 4ccb67ba6f5370b1d16b087e3e714de3e5ae604e
 SHA1 (patch-ah) = c7cbd4b9ea0796ea3b7491c2cffb6ddddc518587

Cheers,
Chris
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (NetBSD)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQFEaquKP65RBOOHTzERAjWAAJ0X8uOLlQVTn18B28nyqsydRTrxJACg5Imv
wN02/NApLgfT4oOih/6OjpU=
=XlKX
-----END PGP SIGNATURE-----