Subject: Re: HEADS UP: Package removal candidates
To: Jim Wise <jwise@draga.com>
From: Dieter Baron <dillo@danbala.tuwien.ac.at>
List: tech-pkg
Date: 12/06/2005 11:10:49
On Mon, Dec 05, 2005 at 06:49:24PM -0500, Jim Wise wrote:
> On Tue, 6 Dec 2005, Thomas Klausner wrote:
>
> >Since Krister has been doing bulk builds for a long while now, I'm
> >quite sure that he knows how to configure bulk builds correctly,
> >so I'm convinced that something's missing or broken in the packages,
> >not the bulk build setup.
>
> With due respect, the setting of `JAVA_HOME' is a basic requirement on
> _all_ platforms on which java is used. It is as elementary as setting
> PATH for unix command line work, or CFLAGS for C development.
However, in pkgsrc, mk/java-vm.mk chooses which JVM is used and sets
PKG_JAVA_HOME accordingly. devel/eclipse has the following line to
make that setting visible to the package build:
MAKE_ENV+= JAVA_HOME=${PKG_JAVA_HOME}
Maybe that would help here also.
> If JAVA_HOME is not set during the bulk build process, the bulk build
> process is in error.
I disagree. pkgsrc chooses which JVM to use (based on user
preferences and what the package can work with), so it's pkgsrc's job
to set JAVA_HOME to the correct value. The infrastructure provides
the correct value in PKG_JAVA_HOME, it's the packages responsibility
to relay that information to the package build process. That is how
other java-using packages work in pkgsrc, and they also work in the
bulk build.
yours,
dillo