Subject: Re: fixing pkglint warnings
To: None <tech-pkg@netbsd.org>
From: Roland Illig <rillig@NetBSD.org>
List: tech-pkg
Date: 12/03/2005 00:25:20
Roland Illig wrote:
> joerg@britannica.bec.de wrote:
> 
>> On Thu, Dec 01, 2005 at 07:14:03PM +0100, Roland Illig wrote:
>>
>>> - Any objections against this?
>>
>>
>>
>> No objection, but please try to commit it in one big swap. It saves the
>> bulk builders a bunch of time :-)
> 
> 
> After a one-day-marathon of going through all packages that had pkglint 
> warnings, this is the result:
> 
>     ftp://ftp.NetBSD.org/pub/pkgsrc/misc/rillig/pkgsrc.diff
>     ftp://ftp.NetBSD.org/pub/pkgsrc/misc/rillig/pkgsrc.diff.gz
> 
> Any volunteers to review it?

If you volunteer you maybe want to have a look at

ftp://ftp.netbsd.org/pub/pkgsrc/misc/rillig/pkgsrc-autofixed.diff
ftp://ftp.netbsd.org/pub/pkgsrc/misc/rillig/pkgsrc-excl-autofixed.diff

which are the changes split to the ones that have been fixed by "pkglint 
--autofix" and the changes excluding those. The latter are far more 
interesting. :)

I have also uploaded the results of a pkglint run before the changes and 
one after the changes, as well as the diff between them:

     ftp://ftp.netbsd.org/pub/pkgsrc/misc/rillig/pkglint.before
     ftp://ftp.netbsd.org/pub/pkgsrc/misc/rillig/pkglint.after
     ftp://ftp.netbsd.org/pub/pkgsrc/misc/rillig/pkglint.diff

The last two lines of the latter file are probably interesting, too:

     -491 errors and 3932 warnings found.
     +470 errors and 1236 warnings found.

Roland