On Thu, Nov 24, 2005 at 03:59:12AM +0000, Ben Collver wrote:
> 
> Module Name:	pkgsrc
> Committed By:	ben
> Date:		Thu Nov 24 03:59:12 UTC 2005
> 
> Modified Files:
> 	pkgsrc/multimedia/mplayer-share: Makefile.common options.mk
> 
> Log Message:
> Add mplayer option for faad2, which uses faad2 from pkgsrc.

Hi,

with this change you made it impossible to use the internal faad2 support:

+ .if !empty(PKG_OPTIONS:Mfaad)
+ CONFIGURE_ARGS+=      --enable-external-faad
+ .  include "../../audio/faad2/buildlink3.mk"
+ .else
+ CONFIGURE_ARGS+=      --disable-external-faad
+ CONFIGURE_ARGS+=      --disable-internal-faad
+ .endif

Please make it possible to still use it instead of the external one.

And you also changed the default settings with this change, without bumping
the PKGREVISION.

Bernd