Subject: Re: PKGREVISION
To: Roland Illig <rillig@NetBSD.org>
From: Johnny C. Lam <jlam@pkgsrc.org>
List: tech-pkg
Date: 10/27/2005 11:04:09
Roland Illig wrote:
> Roland Illig wrote:
> 
>> Module Name:    pkgsrc
>> Committed By:    rillig
>> Date:        Wed Oct 26 23:17:49 UTC 2005
>>
>> Modified Files:
>>     pkgsrc/pkgtools/pkglint: Makefile
>>     pkgsrc/pkgtools/pkglint/files: makevars.map pkglint.pl
>>
>> Log Message:
>> Updated pkglint to 4.31.
>>
>> [...] It is now an error if PKGREVISION appears outside a package
>> Makefile.
> 
> 
> Does anyone have a problem with this change? Or with my decision of 
> making it an error instead of a warning? After all, this variable is 
> meant to be set per individual package, isn't it?

This one is absolutely correct.  I had swept pkgsrc many months ago to 
fix this at the time, but this error continue to crop up again and again.

	Thanks,

	-- Johnny Lam <jlam@pkgsrc.org>