Subject: Re: pkgviews lost on perl
To: Johnny Lam <jlam@NetBSD.org>
From: =?UTF-8?Q?C=C3=A9sar_Catri=C3=A1n?= C. <ccatrian@eml.cc>
List: tech-pkg
Date: 08/11/2005 17:51:45
On Tue, 09 Aug 2005 19:03:00 -0400
Johnny Lam <jlam@NetBSD.org> wrote:

> César Catrián C. wrote:
> > The pkgviews option available in lang/perl5 was lost on version 1.97 of the
> > package's Makefile. Is there a problem with perl and pkgviews?
> 
> It's simply untested with the perl update, and there were significant 
> pkgsrc changes to the perl package which made it necessary to "re-port" 
> the package to use the existing pkgviews implementation.  If you can 
> figure out how to integrate it into the new perl package, I encourage 
> you to submit patches for it.  I don't have the resources to undertake it.
> 

PERL5 is redefined in mk/tools/perl.mk . The PERL5 definition in perl.mk does
not apply to the perl package.

Perl + pkgviews builds fine to me with this patch. Please review.

--- mk/tools/perl.mk.orig       2005-08-11 16:07:13.000000000 -0400
+++ mk/tools/perl.mk    2005-08-11 16:26:51.000000000 -0400
@@ -54,10 +54,12 @@
 # Some packages want the path to the perl tool, even if they don't have
 # dependency on perl, e.g. devel/cvs.
 #
+.if !defined(PERL5)
 .  if defined(TOOLS_PLATFORM.perl) && !empty(TOOLS_PLATFORM.perl)
 TOOLS_${_TOOLS_VARNAME.perl}?= ${TOOLS_PLATFORM.perl}
 .  else
 TOOLS_${_TOOLS_VARNAME.perl}?= ${LOCALBASE}/bin/perl
 .  endif
 ${_TOOLS_VARNAME.perl}?=       ${TOOLS_${_TOOLS_VARNAME.perl}}
+.  endif
 .endif

regards

César Catrián C.