Subject: Re: Malformed conditionals
To: grant beattie <grant@NetBSD.org>
From: Jake Maciejewski <maciejej@msoe.edu>
List: tech-pkg
Date: 07/08/2005 23:31:05
On Sat, 2005-07-09 at 13:15 +1000, grant beattie wrote:
> On Sat, Jul 09, 2005 at 01:09:42PM +1000, grant beattie wrote:
> 
> > On Fri, Jul 08, 2005 at 09:17:13PM -0500, Jake Maciejewski wrote:
> > 
> > > bmake: "../../mk/wrapper/../../mk/buildlink3/../../x11/Xrandr/../../mk/wrapper/../../mk/buildlink3/../../x11/Xrandr/builtin.mk" line 1: Malformed conditional (!empty(BUILTIN_X11_VERSION.${X11_TYPE}:M6.[7-9]*))
> > 
> > this is the result of not using .if defined(...) before testing the
> > value of a variable. pkgsrc folks, we must always test for
> > defined(...) to avoid this.
> > 
> > it should be as simple as changing
> > 
> > 	.if !empty(BUILTIN_X11_VERSION.${X11_TYPE}:M6.[7-9]*)
> > 
> > to
> > 
> > 	.if defined(BUILTIN_X11_VERSION.${X11_TYPE}) && !empty(...)
> 
> Jake,
> 
> I just committed a fix for this. please let me know if it works for
> you now.

Nope. It seems that it's trying to test the conditional anyway.

bmake: "../../mk/wrapper/../../mk/buildlink3/../../x11/Xrender/../../mk/wrapper/../../mk/buildlink3/../../x11/Xrender/builtin.mk" line 1: Malformed conditional (!empty(BUILTIN_X11_VERSION.${X11_TYPE}:M6.[7-9]*))

That's with the latest CVS too, so it's not my mistake fixing it
locally.

> 
> grant.
> 
-- 
Jake Maciejewski <maciejej@msoe.edu>