On Wed, 2005-06-01 at 15:05 +0200, Thomas Klausner wrote:
> On Wed, Jun 01, 2005 at 03:00:46PM +0000, Julio M. Merino Vidal wrote:
> > I've added:
> > 
> > .if ${MACHINE_ARCH} == "i386"
> > PKG_OPTIONS_LEGACY_VARS+= \
> >     MPLAYER_ENABLE_RUNTIME_CPU_DETECTION:mplayer-runtime-cpudetection
> > .endif
> > 
> > But it seems to do nothing.  At least, the corresponding option is not
> > added by default, although the variable is explicitly set to YES by
> > mk/defaults/mk.conf.
> 
> Do you have bsd.prefs.mk included before the MACHINE_ARCH test?
> Is your pkgsrc up-to-date?
> I can't think of anything else. Look at e.g. audio/lame/options.mk
> for a case where it works.

Hmm it seems to be a bug in PKG_OPTIONS_LEGACY_VARS handling.  If I
remove the dashes from the option name, it works.  Johnny?

> > > Option descriptions for all options (including the package-specific
> > > ones) should be added to mk/defaults/option.descriptions.
> > 
> > Nice!  I wasn't aware of that file; it makes 'make show-options' output
> > quite user-friendly :)
> 
> Yes :)
> Now we only need all options described there....

Indeed; I've described all the ones I used and the new ones, though.

-- 
Julio M. Merino Vidal <jmmv84@gmail.com>
http://www.livejournal.com/users/jmmv/
The NetBSD Project - http://www.NetBSD.org/