Subject: Re: Variable to show all used builtin packages?
To: Juan RP <juan@xtrarom.org>
From: Johnny C. Lam <jlam@NetBSD.org>
List: tech-pkg
Date: 05/24/2005 11:35:07
Juan RP wrote:
> Index: buildlink3/bsd.builtin.mk
> ===================================================================
> RCS file: /cvsroot/pkgsrc/mk/buildlink3/bsd.builtin.mk,v
> retrieving revision 1.3
> diff -u -r1.3 bsd.builtin.mk
> --- buildlink3/bsd.builtin.mk 10 Nov 2004 17:39:03 -0000 1.3
> +++ buildlink3/bsd.builtin.mk 24 May 2005 15:18:46 -0000
> @@ -146,4 +146,9 @@
> #
> .for _pkg_ in ${BUILDLINK_PACKAGES}
> USE_BUILTIN.${_pkg_}?= no
> +SHOW_BUILTIN?= # empty
> +. if !empty(USE_BUILTIN.${_pkg_}:M[Yy][Ee][Ss])
> +SHOW_BUILTIN+= ${_pkg_}
> +. endif
> .endfor
> +
>
> Is ok to commit?
Yes, this is fine, but please call the variable "BUILTIN_PACKAGES"
instead of "SHOW_BUILTIN", and amend the comment above the for loop to
note what BUILTIN_PACKAGES will hold.
Cheers,
-- Johnny Lam <jlam@NetBSD.org>