Subject: Re: CVS commit: pkgsrc/mk
To: Julio M. Merino Vidal <jmmv84@gmail.com>
From: Johnny C. Lam <jlam@NetBSD.org>
List: tech-pkg
Date: 05/21/2005 22:24:40
On Sun, May 22, 2005 at 12:03:19AM +0000, Julio M. Merino Vidal wrote:
> On Sat, 2005-05-21 at 21:40 +0000, Johnny C. Lam wrote:
> > Module Name: pkgsrc
> > Committed By: jlam
> > Date: Sat May 21 21:40:45 UTC 2005
> >
> > Modified Files:
> > pkgsrc/mk: bsd.pkg.patch.mk
> >
> > Log Message:
> > Make a bad patch cause a fatal error again. This fixes a bug introduced
> > in revision 1.5 and fixes PR pkg/30297.
>
> I'm wondering if it'd be possible to make it fail after all the patches
> have been applied, not after the first one that fails.
Actually, this is what I implemented in bsd.pkg.patch.mk if I read my
code correctly.
> Why? When I'm updating a package, I do 'make patch', see that one of
> the first patches fails and fix it manually. Then, I have to 'make
> clean' and 'make patch' again, to find later that another one breaks.
> This gets annoying after a few times. Aren't you bitten by this same
> "problem" or do you do things in a different way?
When I update packages, I usually apply patches by hand one-by-one,
but now I think I'll just run "make patch" since it will apply all of
them :)
Cheers,
-- Johnny Lam <jlam@NetBSD.org>