Subject: Re: how to deal with USE_INET6 and BUILD_DEFS?
To: Georg Schwarz <georg.schwarz@freenet.de>
From: Lubomir Sedlacik <salo@Xtrmntr.org>
List: tech-pkg
Date: 03/04/2005 15:54:45
--VS++wcV0S1rZb1Fb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

hi,

On Fri, Mar 04, 2005 at 03:48:40PM +0100, Georg Schwarz wrote:
> pkgsrc/chat/eggdrop/Makefile has
>=20
> .if defined(USE_INET6) && !empty(USE_INET6:M[Yy][Ee][Ss])
> BUILD_DEFS+=3D            USE_INET6
> CONFIGURE_ARGS+=3D        --enable-ipv6
> ....
>=20
> It does not make sense to add USE_INET6 to BUILD_DEFS only if
> USE_INET6 is yes, does it?
> What would be the proer way of handling this?  Should it be checked
> whether the system could at all use IPv6, and only in that case add
> USE_INET6 to BUILD_DEFS, or add it unconditionally?

you seem to have it backwards.

system, which couldn't at all use IPv6 should not set USE_INET6.
BUILD_DEFS should contain USE_INET6 only when it's set, BUILD_DEFS is a
list of options the package was built with.


regards,

--=20
-- Lubomir Sedlacik <salo@{NetBSD,Xtrmntr,silcnet}.org>   --

--VS++wcV0S1rZb1Fb
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)

iD8DBQFCKHa1iwjDDlS8cmMRAvhiAJ9ZeEw9qLWoaKXX6SzuGRgMbtj/kgCfWHIt
bbiFbnEAWRipV1SShI8T/5o=
=fQQI
-----END PGP SIGNATURE-----

--VS++wcV0S1rZb1Fb--