On Tue, 15 Feb 2005 uebayasi@pultek.co.jp wrote:

> I'm slowly changing Makefile's that seem broken due to wrongly quoted
> variables in command-line, after Todd's recent bsd.pkg.mk changes.  My
> changes (which originally recht@ did for devel/glib2) are simply doing
>
> 	FOO=	\\\"${FOO}\\\"
> 	FOO=	\"\\\"${FOO}\\\"\"
>
> to
>
> 	FOO=	"\"${FOO}\""
>
> Both of the fomers are broken when the definitions are passed to as a
> part of CFLAGS.  In most cases, configure fails as ${CC} ${CFLAGS}
> won't run.  I'm not very sure about all cases, but the latter
> ("\"${FOO}\"") looks much saner and less broken to me.

This looks correct to me too.  My message did not mention the extra quotes
(for the shell's benefit, not for make's).

Thank you for the help.  I was going to do a script-based sweep through
today if no one beat me to it.  :)

-- 
-- Todd Vierling <tv@duh.org> <tv@pobox.com>