Subject: Re: pkgtools/x11-links permissions
To: None <tech-pkg@netbsd.org>
From: Jonathan Perkin <jonathan@perkin.org.uk>
List: tech-pkg
Date: 02/01/2005 13:37:59
* On 2005-02-01 at 13:04 GMT, Ian D. Leroux wrote:
> Any other comments or suggestions or should I file a PR?
>
> - ${MKDIR} ${X11_LINKS_BUILD_DIR}
> + ${MKDIR} -m ${PKGDIRMODE} ${X11_LINKS_BUILD_DIR}
My only suggestion is that you may be better off using one of the
INSTALL_<mumble>_DIR macros, incase one of our supported platforms
doesn't support the "-m" argument to mkdir, and to possibly aid
readability.
See pkgsrc/mk/bsd.pkg.mk around line 624.
Cheers,
--
Jonathan Perkin The NetBSD Project
http://www.perkin.org.uk/ http://www.netbsd.org/