Subject: Re: incorrect file attributes for abiword
To: None <adam@NetBSD.org>
From: Jeremy C. Reed <reed@reedmedia.net>
List: tech-pkg
Date: 01/27/2005 10:41:38
On Thu, 27 Jan 2005, Jeremy C. Reed wrote:

> I compared them myself:
>
> $ diff -pruN {old,new}/abiword-2.2.3 2>&1 | tee abiword.diff
> diff -pruN old/abiword-2.2.3/abiword-plugins/tools/ots/xp/AbiOts.cpp new/abiword-2.2.3/abiword-plugins/tools/ots/xp/AbiOts.cpp
> --- old/abiword-2.2.3/abiword-plugins/tools/ots/xp/AbiOts.cpp	2005-01-12 20:04:37.000000000 +0000
> +++ new/abiword-2.2.3/abiword-plugins/tools/ots/xp/AbiOts.cpp	2005-01-14 23:24:52.000000000 +0000
> @@ -92,7 +92,7 @@ AbiOts_invoke(AV_View* v, EV_EditMethodC
>    XAP_Frame *pFrame = XAP_App::getApp()->getLastFocussedFrame();
>    FV_View* pView = static_cast<FV_View*>(pFrame->getCurrentView());
>
> -  const unsigned char * dictionary_file = reinterpret_cast<const unsigned char *>(XAP_EncodingManager::get_instance()->getLanguageISOName());
> +  const char * dictionary_file = XAP_EncodingManager::get_instance()->getLanguageISOName();
>
>    OtsArticle * article = ots_new_article ();
>    if (!ots_load_xml_dictionary (article, dictionary_file))
>
>
> No changelog changes in tar ball though. I will ask the abiword
> developers about this...

Adam: Before I ask abiword-dev, where did you get your tarball from?

I see you updated this on January 13.

From the CVS commit messages for abiword (not pkgsrc), it appears that it
was not available until January 15 and was officially announced on January
17.

I guess we should use DIST_SUBDIR to force this to be fixed and update the
distinfo.

Can you do this?

Also can you update abiword-plugins' PLIST and distinfo also (since they
require same distfile)?

Thank you,

 Jeremy C. Reed

 	  	 	 open source, Unix, *BSD, Linux training
	  	 	 http://www.pugetsoundtechnology.com/