Subject: Re: mtr on Mac OS X
To: None <tech-pkg@netbsd.org>
From: Frederick Bruckman <fredb@immanent.net>
List: tech-pkg
Date: 01/09/2005 20:48:50
In article <Pine.NEB.4.61.0501091228250.3608@lain.ziaspace.com>,
John Klos <john@ziaspace.com> writes:
>>> patch-ab already patches dns.c. And since nameser8_compat.h and
>>> resolv8_compat.h are no good for other systems, I'm not quite sure how to
>>> have a conditional patch. Does anyone know of any good examples?
>>
>> Conditional patch?! #ifdef, dood!
>
> I was wondering if there was some mechanism that allowed for selective
> patching (simply choosing this patch or that patch, for instance). #ifdef
> it is!
Just to be clear, that's "#ifdef", not ".ifdef". Do a conditional
compile, not a conditonal patch. We used to permit conditional patches,
but it's a maintenance nightmare, doesn't scale well as you add support
for more platforms, and worst of all, can't be accepted by the upstream.
Frederick