Subject: Re: glib2/gettext problem
To: Min Sik Kim <minskim@NetBSD.org>
From: Johnny C. Lam <jlam@NetBSD.org>
List: tech-pkg
Date: 11/28/2004 05:31:54
On Sat, Nov 27, 2004 at 11:52:24AM -0600, Min Sik Kim wrote:
>
> I think gettext-lib/builtin.mk fails to detect libintl. Please try
> the following patch.
>
> Index: devel/gettext-lib/builtin.mk
> ===================================================================
> RCS file: /cvsroot/pkgsrc/devel/gettext-lib/builtin.mk,v
> retrieving revision 1.14
> diff -u -r1.14 builtin.mk
> --- devel/gettext-lib/builtin.mk 26 Nov 2004 23:16:35 -0000 1.14
> +++ devel/gettext-lib/builtin.mk 27 Nov 2004 17:43:59 -0000
> @@ -3,12 +3,12 @@
> .for _lib_ in intl
> . if !defined(_BLNK_LIB_FOUND.${_lib_})
> _BLNK_LIB_FOUND.${_lib_}!= \
> - if ${TEST} "`${ECHO} /usr/lib/lib${_lib_}.*`" = "/usr/lib/lib${_lib_}.*"; then \
> - ${ECHO} "no"; \
> - elif ${TEST} "`${ECHO} /lib/lib${_lib_}.*`" = "/lib/lib${_lib_}.*"; then \
> - ${ECHO} "no"; \
> - else \
> + if ${TEST} "`${ECHO} /usr/lib/lib${_lib_}.*`" != "/usr/lib/lib${_lib_}.*"; then \
> ${ECHO} "yes"; \
> + elif ${TEST} "`${ECHO} /lib/lib${_lib_}.*`" != "/lib/lib${_lib_}.*"; then \
> + ${ECHO} "yes"; \
> + else \
> + ${ECHO} "no"; \
> fi
> BUILDLINK_VARS+= _BLNK_LIB_FOUND.${_lib_}
> . endif
Your change to reverse the test makes a great deal more sense than the
way I had written it. Thanks for the idea -- there are several other
builtin.mk files that I will now modify in the same way.
Cheers,
-- Johnny Lam <jlam@NetBSD.org>