On Mon, Nov 01, 2004 at 12:37:51PM -0800, Jeremy C. Reed wrote:
> On Mon, 1 Nov 2004, Eric Haszlakiewicz wrote:
> > Possible issues:
> > 1) Upgrading to a package that has fewer/different files.  This isn't
> > 	all that hard to fix, but it'll take more time than I have to work
> > 	on it today.
> 
> My custom pkg_add tool attempts to remove files from old package after it
> installs the new package. (It has an installation that doesn't do a
> pkg_delete first.)

	ah, cool!  So is that going to replace the existing pkg_add at some
point?
	It seems a bit of a shame that we've got features like this that need
to be duplicated across the pkg_* binaries and pkgsrc.  Have you thought
of maybe pulling a bunch of that script out of the makefiles into a base
packages script library that both pkgsrc and the other tools could use?

> > 2) "make install" no longer means "make update" (do we care?)
> > 3) I have no idea how this interacts with pkgviews or whether anything
> > 	special needs to be done there.
> 
> One concern I have is preserving the information in the +REQUIRED_BY
> files. In this pkg_install case, it doesn't matter, but if this was to be
> used for other packages, it might be important.

	That should already be handled, although I haven't tested it.  See
the references to +REQUIRED_BY in the defintion of _REPLACE in bsd.pkg.mk.

> Also why the "-f -f" in the following?
> +real-su-deinstall-flags+=      -N -f -f
> 
> Maybe it shouldn't need to be forced whern using -N.

	I think it's still a good idea to make it somewhat difficult to
remove a PKG_PRESERVE package.  I'll change it so it only needs a single
-f if -N is specified.

eric