Subject: Re: annoying warnings from pkglint
To: D'Arcy J.M. Cain <darcy@NetBSD.org>
From: Dave <dgriffi@cs.csubak.edu>
List: tech-pkg
Date: 10/29/2004 13:28:49
On Fri, 29 Oct 2004, D'Arcy J.M. Cain wrote:
> On Fri, 29 Oct 2004 00:46:04 -0700 (PDT)
> Dave <dgriffi@cs.csubak.edu> wrote:
> >
> > I've just put together a new package for cpmtools (like mtools, but
> > for CP/M filesystems). Here's the problem:
>
> Cool. I may have to clean up my CP/M emulator and submit that too. :-)
What emulator is that? I'm partial to yaze-ag. But there's something to
be said about homebrewing too. I'm making a new run of the old P112
boards. Let me know if you want any.
> > zaphod:/usr/pkgsrc/sysutils/cpmtools$ pkglint
> > WARN: possible direct use of command "file" found. Use ${FILE_CMD}
> > instead. WARN: "BUILD_DEPENDS" has to appear earlier.
> > 0 errors and 2 warnings found.
>
> Yah, two issues here. Number 1 is the use of the word "file" in
> autoconf.mk. Pkglint is a little simplistic and can't tell the
> difference between the use of "file" as a command or as a variable. I
> have just submitted a fix that will take care of that one for you.
>
> The second is a little harder because it is checking that things come in
> the right order. The problem is that since this is in an included file
> it is hard to insert things in the right place in your file. The best
> thing you can do for now, I think, is just to make sure that the problem
> is not in your package (which you have done by removing the offending
> file to check) and submit it.
That's what I was considering doing anyhow. Thanks.
--
David Griffith
dgriffi@cs.csubak.edu