Subject: Re: unzip doesn't need gmake
To: Johnny C. Lam <jlam@NetBSD.org>
From: Julio M. Merino Vidal <jmmv@menta.net>
List: tech-pkg
Date: 09/25/2004 11:00:15
On Fri, 24 Sep 2004 22:33:55 +0000
"Johnny C. Lam" <jlam@NetBSD.org> wrote:
> On Fri, Sep 24, 2004 at 02:37:06PM -0700, Jeremy C. Reed wrote:
> > It appears that archivers/unzip doesn't need gmake.
> >
> > Can someone else confirm?
> >
> > --- archivers/unzip/Makefile 1 Jun 2004 04:31:42 -0000 1.49
> > +++ archivers/unzip/Makefile 24 Sep 2004 21:36:05 -0000
> > @@ -13,7 +13,6 @@
> >
> > WRKSRC= ${WRKDIR}/${PKGNAME_NOREV}
> > USE_BUILDLINK3= yes
> > -USE_GNU_TOOLS+= make
> >
> > .include "../../mk/bsd.prefs.mk"
>
> "cvs annotate" is your friend. It says that it was added by xtraeme
> in revision 1.47 because it's needed on OpenBSD. I don't see why that
> should be the case since they also use BSD make, but maybe someone
> else can shed some light on this.
Humm... I always thought bootstrapped platforms never used the system make,
but instead they used our own bmake to build everything. But as it seems
from this change to unzip (and AFAICS in our .mk files), this is false.
The problem here might be because unzip's Makefile calls make sometimes as
'make', not $(MAKE).
If we are not using bmake, I think we should link bmake into TOOLS_DIR/bin/make
unconditionally (well, except when gmake is to be used). This could make
packages behave in a deterministic way, because the make utility could be
always the same across systems.
Cheers
--
Julio M. Merino Vidal <jmmv@menta.net>
http://www.livejournal.com/users/jmmv/
The NetBSD Project - http://www.NetBSD.org/