--oC1+HKm2/end4ao3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

"Johnny C. Lam" <jlam@NetBSD.org> wrote:
> On Sat, Sep 11, 2004 at 05:54:05PM +0000, Jan Schaumann wrote:
> >=20
> > Module Name:	pkgsrc
> > Committed By:	jschauma
> > Date:		Sat Sep 11 17:54:05 UTC 2004
> >=20
> > Modified Files:
> > 	pkgsrc/textproc/nbsed/files: config.h.in configure
> >=20
> > Log Message:
> > Remove check for getprogname, setprogname and fgetln, consistent with
> > jlam's last change, since we use libnbcompat.  (If we left these checks=
 in,
> > configure would test for them, find them and set HAVE_GETPROGNAME, subs=
equently
> > breaking 'getprogname', as nbcompat.h wouldn't work since HAVE_GETPROGN=
AME
> > is then defined.)
>=20
> I wonder why this change was necessary at all.  Within pkgsrc and for
> the bootstrap process, nbsed is configured with -lnbcompat passed to
> the compiler/linker, so those function checks for fgetln() and
> {get,set}progname() should show that they exist (because they exist
> in libnbcompat.a).  Was this not working on your machine?

It wasn't working on my IRIX system.

During configure phase, we compile with -lnbcompat, so configure will
determine that we have getprogname, setprogname and fgetln and set
HAVE_GETPROGNAME etc. accordingly.

During the build phase, we include nbcompat.h, which in turn includes
nbcompat/stdio.h.  That file includes the lines:

#if !HAVE_FGETLN
char    *fgetln(FILE *, size_t *);
#endif

Since during configure phase HAVE_FGETLN was set to 1, the function
protoype is now not defined in our program, causing the build to fail.

Similarly for nbcompat/stdlib.h and HAVE_SETPROGNAME.

-Jan

--=20
Time is an illusion, lunchtime doubly so.

--oC1+HKm2/end4ao3
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (NetBSD)

iD8DBQFBRH4dfFtkr68iakwRAhVjAKCM/mvnVjeafRtGCcdZCXy57LaM/gCfRtda
JoF9i68Wb5LSc0gtX0UgdWU=
=u6Up
-----END PGP SIGNATURE-----

--oC1+HKm2/end4ao3--