Greetings!

I've found that BDB_TYPE may not match any value from BDB_ACCEPTED (see
pkgsrc/mk/bdb.buildlink.mk file). This looks incorrect. For example, in
package Makefile we put:

	BDB_ACCEPTED=	db3 db4

And then it is possible to build this package against db2 (!):

	make BDB_TYPE=db2

The following patch fixes this:

Index: bdb.buildlink3.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/bdb.buildlink3.mk,v
retrieving revision 1.11
diff -u -r1.11 bdb.buildlink3.mk
--- bdb.buildlink3.mk	10 Jul 2004 03:05:46 -0000	1.11
+++ bdb.buildlink3.mk	19 Aug 2004 11:31:46 -0000
@@ -123,7 +123,7 @@
 
 .endif	# BDB_BUILDLINK3_MK
 
-.if ${BDB_TYPE} == "none"
+.if ${BDB_TYPE} == "none" || empty(BDB_ACCEPTED:M${BDB_TYPE})
 PKG_FAIL_REASON=	"No acceptable Berkeley DB implementation found."
 .else
 .  if ${BDB_TYPE} == "native"

Your opinion?

--
Best wishes,
Mishka.