Subject: Re: CVS commit: pkgsrc/devel/gdb6
To: None <tech-pkg@NetBSD.org>
From: Julio M. Merino Vidal <jmmv@menta.net>
List: tech-pkg
Date: 06/03/2004 21:15:54
On Thursday 03 June 2004 21:09, Jeremy C. Reed wrote:
> On Thu, 3 Jun 2004, John R. Shannon wrote:
> > Log Message:
> > Revised Makefile so that the GNU libraries: libbfd.a, libbfd.la,
> > libiberty.a libmmalloc.a, libopcodes.a, and libopcodes.la along with
> > associated header files are installed relative to ${PREFIX}/gdb6 rather
> > than ${PREFIX} to avoid conflicts with other packages. PLIST adjusted
> > accordingly.
>
> I'd prefer that we didn't clutter up ${PREFIX}. (Other packages do this
> too.) In my case, I use LOCALBASE as /usr on several machines.
>
> Can you consider doing something like the following instead?
>
> CONFIGURE_ARGS+=	--libdir=${PREFIX}/lib/${GDB_SUBPREFIX}
> CONFIGURE_ARGS+= 	--includedir=${PREFIX}/include/${GDB_SUBPREFIX}
>
> And then PLIST like:
> include/${GDB_SUBPREFIX}/bfdlink.h
> ...
> lib/${GDB_SUBPREFIX}/libbfd.a

Indeed.

> Also, if you are going to use some variable to define this (GDB_SUBPREFIX
> and GDB_PREFIX), you may want to use them in the PLIST too (with
> PLIST_SUBSTR). If those variables aren't used anywhere else, I'd just get
> rid of them.

I don't think it's worth to add such a variable (if it's only used in
configure arguments and in the PLIST).  If it is added, you'll need extra
PRINT_PLIST_AWK magic to get the right thing during 'make print-PLIST'.

Cheers

-- 
Julio M. Merino Vidal <jmmv@menta.net>
The NetBSD Project - http://www.NetBSD.org/