Subject: Re: libnbcompat poll changes break in FreeBSD.
To: Julio M. Merino Vidal <jmmv@menta.net>
From: Juan RP <juan@xtraeme.unixbsd.org>
List: tech-pkg
Date: 04/23/2004 12:22:39
--Signature=_Fri__23_Apr_2004_12_22_39_+0200_4jB3ajvBfJSptOkT
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

On Fri, 23 Apr 2004 12:15:49 +0200
"Julio M. Merino Vidal" <jmmv@menta.net> wrote:

> +       AC_DEFINE(HAVE_POLL, 1)
> +       AH_TEMPLATE([HAVE_POLL], [
> +               Define to 1 if you have the poll() function.
> +       ])
> 
> That should not be needed.  AC_CHECK_FUNC automatically adds such template
> to config.h.in (check by running autoheader).  Maybe the problem was that
> somebody forgot to regen config.h.in after modifying configure.in...

Why is not needed? I don't see HAVE_POLL defined anywhere, and it's really
needed if you want to use poll, sys/poll.h when building pkg_install, nbcompat.h
contains:

#if HAVE_POLL
# if HAVE_POLL_H
#  include <poll.h>
# elif HAVE_SYS_POLL_H
#  include <sys/poll.h>
# endif
#else
# include <nbcompat/poll.h>
#endif

If HAVE_POLL is not defined, we'll pick up nbcompat/poll.h, do am I
understanding this right?

-- 
	Juan RP <juan@xtraeme.unixbsd.org>

--Signature=_Fri__23_Apr_2004_12_22_39_+0200_4jB3ajvBfJSptOkT
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (NetBSD)

iD8DBQFAiO5vypkLYVDran0RAs57AKDOwx19DpCC+B2lQr9IYpTV3MovbwCdH6Sb
dGXzj9I2fJqEcV7aCcxLY50=
=/KQg
-----END PGP SIGNATURE-----

--Signature=_Fri__23_Apr_2004_12_22_39_+0200_4jB3ajvBfJSptOkT--