On Mon, 29 Mar 2004, Todd Vierling wrote:
> : The umask one never hit me on Unix (I tried Linux & Solaris as non-root).
> ...but as two different users with the same gid?

No. Actually, I didn't use pkg_add, only compiled things.


> : Looking at it, I wonder if we should fiddle with umask at all, or just
> : remove the setting of umask.
>
> I'd fully favor removing the umask call altogether.  IMHO, the sysadmin
> should DTRT, and when running as root, the umask shouldn't matter.

So, go for it!


> : The "warn if we're not root" one - probably makes only sense on Windows
> : based systems, and should probably be #ifdef'ed as such. (Your patch looks
> : ok, dunno if we'll encounter the same thing on cygwin).
>
> Well, I can commit this one as-is; I just didn't want to make it an internal
> OS dependency that will annoy folks in the future.

Well, you sure can add autoconf tricks, but it's probably ok for a start.
People maintaining pkgsrc/bootstrap may have an opinion (but I don't know
who they are these days... hey everyone, update src/doc/RESPONSIBLE! :)

  - Hubert

-- 
Hubert Feyrer <hubert@feyrer.de>