Subject: Re: hard-coded -O3 in audio/flac (and probably elsewhere)
To: Georg Schwarz <geos@epost.de>
From: Johnny C. Lam <jlam@NetBSD.org>
List: tech-pkg
Date: 01/24/2004 00:40:11
--+HP7ph2BbKc20aGI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Jan 24, 2004 at 12:03:39AM +0100, Georg Schwarz wrote:
> 
> Ultimately the package still does not compile on IRIX 5.3 so far,
> because it assumes having snprintf (any idea for a fix to this?); still
> I suggest considering to simply remove (probably patch away) the
> hard-coded -O3's by pkgsrc.
> What's the opinion on that issue?

Can you please try the attached patch?

	Cheers,

	-- Johnny Lam <jlam@NetBSD.org>

--+HP7ph2BbKc20aGI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="flac.diff"

? flac.diff
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/audio/flac/Makefile,v
retrieving revision 1.16
diff -u -r1.16 Makefile
--- Makefile	22 Jan 2004 07:15:00 -0000	1.16
+++ Makefile	24 Jan 2004 00:38:21 -0000
@@ -17,7 +17,7 @@
 .endif
 
 WRKSRC=			${WRKDIR}/${PKGNAME_NOREV}
-USE_BUILDLINK2=		yes
+USE_BUILDLINK3=		yes
 USE_GNU_TOOLS+=		make
 GNU_CONFIGURE=		yes
 CONFIGURE_ENV+=		ac_cv_path_XMMS_CONFIG="no"
@@ -25,5 +25,9 @@
 USE_LIBTOOL=		yes
 LIBTOOL_OVERRIDE=	${WRKSRC}/libtool
 
-.include "../../audio/libogg/buildlink2.mk"
+.if defined(USE_MIPSPRO) && (${OPSYS} == "IRIX")
+BUILDLINK_TRANSFORM+=	S:-O3:
+.endif
+
+.include "../../audio/libogg/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"

--+HP7ph2BbKc20aGI--