Subject: Re: EXTRACT_CMD needs EXTRACT_CMD_OPTS
To: None <tech-pkg@NetBSD.org>
From: Michal Pasternak <michal@pasternak.w.lub.pl>
List: tech-pkg
Date: 11/22/2003 20:52:22
--/04w6evG8XlLl3ft
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline

Johnny C. Lam [Sat, Nov 22, 2003 at 07:26:32PM +0000]:
> This sounds like a very good idea.  I'll be happy to review a patch
> for this.

Attached. Implementing this option for other archivers (lha/zoo/others)
would be overkill - they just don't need it, because they don't have options
as much changing their output, as "-L" of unzip.

I've tested it, works okay, gives proper results.

Regards,
-- 
Michal Pasternak :: http://pasternak.w.lub.pl

--/04w6evG8XlLl3ft
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: attachment; filename="unzip_patch.diff"

--- bsd.pkg.mk.orig	Sat Nov 22 20:40:43 2003
+++ bsd.pkg.mk	Sat Nov 22 20:46:07 2003
@@ -2032,7 +2032,8 @@
 
 DOWNLOADED_DISTFILE=	$${extract_file}
 
-EXTRACT_CMD.zip?=	${LOCALBASE}/bin/unzip -Laqo $${extract_file}
+EXTRACT_CMD.zip?=	${LOCALBASE}/bin/unzip ${EXTRACT_OPTS.zip} $${extract_file}
+EXTRACT_OPTS.zip?=	-Laqo
 EXTRACT_CMD.lha?=	${LOCALBASE}/bin/lha xq $${extract_file}
 EXTRACT_CMD.lzh?=	${EXTRACT_CMD.lha}
 EXTRACT_CMD.zoo?=	${LOCALBASE}/bin/unzoo -x $${extract_file}

--/04w6evG8XlLl3ft--