Subject: Re: pkgsrc on hurd and some patches...
To: grant beattie <grant@netbsd.org>
From: Alistair Crooks <agc@wasabisystems.com>
List: tech-pkg
Date: 06/23/2003 12:31:08
On Sun, Jun 22, 2003 at 02:31:43PM +1000, grant beattie wrote:
> On Sat, Jun 21, 2003 at 12:43:30PM +0200, pancake wrote:
> 
> > True, I test asprintf on Solaris for example, and it does not exists...the correct solution must be write the Hurd patch inside #if __GNU__ directives.
> 
> someone submitted some diffs for bootstrap-pkgsrc on Hurd - I picked
> up the PR but have not yet integrated them.
> 
> testing for __GNU__ is something to be avoided unless absolutely
> necessary, imho.

Yes, as Grant says, the test should be

#ifdef HAVE_ASPRINTF
...
#endif

I would have thought - that was the problem I had with the original
Hurd patches as submitted.

Regards,
Alistair