Thanks for reviewing this package. I've since implemented your
suggested changes and re-tested the application. I now feel confident
to submit this package later tonight...

cheerio Berndt

Johnny Lam wrote
> On Wed, Dec 01, 2021 at 09:11:30PM +1030, Berndt Josef Wulf wrote:
> > 
> > The package source can be found on
> > 
> > ftp://ftp.netbsd.org/pub/NetBSD/misc/wulf/uml-1.0.3-pkgsrc.tar.gz
> > 
> > I would like to ask you to give this package a spin providing me with
> > some feedback. A lot has changed since I last submitted a new package
> > and it definitely would give me confidence boost... ;-)
> 
> I took a look at your package since I think I most recently touched all of
> the KDE2 packages in our tree.  It looks good with only a few minor changes
> that I made:
> 
>      1) prdownloads.sourceforge.net is part of ${MASTER_SITE_SOURCEFORGE}
> 	so we use the latter instead.
> 
>      2) We need to set AUTOMAKE_OVERRIDE=YES so that KDE2's automake procedure
> 	doesn't run again and clobber any changes we make to the configure
> 	scripts or Makefiles.  In general, unless you've patched the actual
> 	autoconf/automake source files, you need to set this.
> 
> 	[Hmm...I should change this so that packages that this is the
> 	 default, and packages that patch the autoconf/automkae source files
> 	 should set AUTOMAKE_OVERRIDE=NO.]
> 
>      3) We don't need the qt2-designer buildlink.mk file because we don't
> 	need the shared libraries.
> 
>      4) I'm not sure why you had the "rm -rf" line in the PLIST, so I fixed
> 	it to allow the pkg_* tools to handle the files and directories
> 	correctly.
> 
> 	Cheers,
> 
> 	-- Johnny Lam <jlam@jgrind.org>
> 
> diff -ur uml.orig/Makefile uml/Makefile
> --- uml.orig/Makefile	Sun Dec  2 03:30:04 2001
> +++ uml/Makefile	Sun Dec  2 13:41:12 2001
> @@ -4,19 +4,21 @@
>  PKGNAME=	uml-1.0.3
>  WRKSRC=		${WRKDIR}/${PKGNAME}
>  CATEGORIES=	devel
> -MASTER_SITES=	http://prdownloads.sourceforge.net/uml/
> +MASTER_SITES=	${MASTER_SITE_SOURCEFORGE:=uml/}
>  
>  MAINTAINER=	wulf@netbsd.org
>  HOMEPAGE=       http://uml.sourceforge.net/
>  COMMENT=	UML Modelling tool
>  
> -BUILD_DEPENDS+= qt2-designer-kde>=2.3.1nb1:../../x11/qt2-designer-kde
> +BUILD_DEPENDS+=	qt2-designer-kde>=2.3.1nb1:../../x11/qt2-designer-kde
>  
> -USE_LIBTOOL=	YES
> -USE_GMAKE=	YES
> -GNU_CONFIGURE=	YES
> +USE_BUILDLINK_ONLY=	YES
> +USE_GMAKE=              YES
> +GNU_CONFIGURE=          YES
> +AUTOMAKE_OVERRIDE=	YES
> +USE_LIBTOOL=            YES
> +LTCONFIG_OVERRIDE=      ${WRKSRC}/admin/ltconfig
>  
> -.include "../../x11/qt2-designer/buildlink.mk"
>  .include "../../x11/kde2/buildlink.mk"
>  .include "../../x11/kdelibs2/buildlink.mk"
>  .include "../../mk/x11.buildlink.mk"
> diff -ur uml.orig/PLIST uml/PLIST
> --- uml.orig/PLIST	Sun Dec  2 06:19:24 2001
> +++ uml/PLIST	Sun Dec  2 13:58:22 2001
> @@ -1,5 +1,4 @@
>  @comment $NetBSD$
> -
>  bin/uml
>  share/kde/apps/uml/pixmaps/actor.xpm
>  share/kde/apps/uml/pixmaps/aggregation.xpm
> @@ -89,9 +88,10 @@
>  share/doc/kde/HTML/en/uml/pics/uc_diagram.png
>  share/doc/kde/HTML/en/uml/pics/uc_prop.png
>  share/doc/kde/HTML/en/uml/pics/icons.png
> +share/doc/kde/HTML/en/uml/common
>  share/doc/kde/HTML/en/uml/index.docbook
>  share/doc/kde/HTML/en/uml/index.cache.bz2
>  @dirrm share/kde/apps/uml/pixmaps
>  @dirrm share/kde/apps/uml
>  @dirrm share/doc/kde/HTML/en/uml/pics
> -@exec  rm -f %D/share/doc/kde/HTML/en/uml
> +@dirrm share/doc/kde/HTML/en/uml
> 


-- 
Name    : Berndt Josef Wulf            | +++ With BSD on Packet Radio +++
E-Mail  : wulf@ping.net.au             |    tfkiss, tnt, dpbox, wampes
ICQ     : 18196098                     |  VK5ABN, Nairne, South Australia 
URL     : http://www.ping.net.au/~wulf | MBOX : vk5abn@vk5abn.#lmr.#sa.au.oc
Sysinfo : DEC AXPpci33+, NetBSD-1.5    | BBS  : vk5abn.#lmr.#sa.aus.oc