Subject: Re: pkg/10704
To: Berndt Josef Wulf <wulf@dingo.ping.net.au>
From: Alistair Crooks <agc@pkgsrc.org>
List: tech-pkg
Date: 02/12/2001 14:09:09
On Tue, Feb 13, 2001 at 12:23:53AM +1030, Berndt Josef Wulf wrote:
> The patches refered to in pkg/PR10704 were successfully tested on a AXPpci33
> and have proven to fix the problems hightlighted in this PR.

Sounds good.
 
> I don't see any reason to further delay the integration of this patch into the
> pkgsrc tree. The following code changes were made to ensure that this patch is 
> applied for NetBSD-alpha architectures only...
> 
> 
> --- Makefile.orig	Tue Feb 13 00:07:03 2001
> +++ Makefile	Tue Feb 13 00:01:19 2001
> @@ -10,7 +10,7 @@
>  MAKEFILE=		GNUmakefile
>  
>  # Needs ELF clue, mips has no TAS implementation
> -NOT_FOR_PLATFORM=	*-*-alpha *-*-mips
> +#NOT_FOR_PLATFORM=	*-*-alpha *-*-mips

I'd prefer to keep the "NOT_FOR_PLATFORM= *-*-mips" in there,
especially if the patch is to be "applied for NetBSD-alpha
architectures only..."

>  .include "../../mk/bsd.prefs.mk"
>  
> @@ -47,6 +47,11 @@
>  .elif ${OPSYS} == "SunOS"
>  ADDUSER=		useradd
>  ADDGROUP=		groupadd
> +.endif
> +
> +.if ${MACHINE_ARCH} == "alpha"
> +post-patch:
> +	cd ${WRKSRC} && ${PATCH} < ${FILESDIR}/postgresql-7.0.3-alpha.diff
>  .endif
>  
>  post-build:

What's the problem with applying the patch in all cases, and using cpp
switches to differentiate what is wanted where? We do that in most of
the other packages we patch.

Regards,
Al