Subject: Re: pkg/11189: pkg tcl-8.3.2 won't compile on i386 1.4.1
To: Todd Vierling <tv@wasabisystems.com>
From: David Rankin <drankin@bohemians.lexington.ky.us>
List: tech-pkg
Date: 10/10/2000 21:34:42
On Tue, Oct 10, 2000 at 05:38:55PM -0400, Todd Vierling wrote:
> On Tue, 10 Oct 2000, David Rankin wrote:

> : /usr/pkg/bin/libtool --mode=link cc -Wl,-R/usr/pkg/lib tclAppInit.o
> : libtcl83.la -lm -lc -Wl,-rpath,/usr/pkg/lib -o tclsh

> I'm not sure where the "-Wl,-rpath" is coming from, as patch-aa shows only
> the "libtool --mode=link -Wl,-R", which is actually not correct either.  
> The suggested fix in the PR may be correct; tcl is trying to do its own
> handling, and botching it:

configure is trying this and "figuring out" that cc "needs" these values.
Since our patches put libtool in outside of configure's knowledge, I would
suggest deleting the references to TCL_LD_SEARCH_FLAGS. If we really do need
the -rpath flags, they should go in the same place as the -R flags.

> : 	On lines 433 and 437 of the file unix/Makefile.in, remove the
> : item @TCL_LD_SEARCH_FLAGS@ . This will prevent the bad -rpath insertion.

While compiling x11/tk 8.2.3, I've discovered the same problem under
unix/Makefile.in. In line 213, you have
TK_CC_SEARCH_FLAGS     = -Wl,-rpath,${LIB_RUNTIME_DIR}:/usr/X11R6/lib
which again sends libtool for a loop, and can be commented out (or moved 
to the libtool call). Should I open another PR for this, or is this one
good enough?

Thanks,
David

-- 
David W. Rankin, Jr.     Husband, Father, and UNIX Sysadmin. 
   Email: drankin@bohemians.lexington.ky.us   Address/Phone Number: Ask me.