Subject: Re: bsd.pkg.mk
To: Frederick Bruckman <fb@enteract.com>
From: Hubert Feyrer <feyrer@rfhs8012.fh-regensburg.de>
List: tech-pkg
Date: 07/25/2000 22:51:38
On Tue, 25 Jul 2000, Frederick Bruckman wrote:
> I don't
> understand what you mean by using IGNORE instead of RESTRICTED.
RESTRICTED is not only used to put into BUILD_DEFS, but the IGNORE
variable is set to it's value as well at some point. Maybe check if that
one needs quoting in the appropriate places, too.
> Maybe it would be good to revisit other occurences of ${ECHO} in
> bsd.pkg.mk. ``${ECHO} "${foo} ${bar}"'' is pretty lame--the quotes
> don't escape very much, especially not exclamation points or quotes,
> so why bother? If there's a concern that "${foo}" contains arbitrary
> characters, ${foo} should become ${foo:Q}, and if there's no concern,
> ${ECHO} doesn't need the quotes.
See above - the reason why i found lynx-current having a problem in the
first place was because the build failed, not because i noticed a broken
build-def noted in the pkg.
> On another note, the export restrictions don't hold anymore. Maybe
> it's about time we garbage collected all the RESTRICTED=Crypto...
Go for it. :-)
- Hubert
--
NetBSD - because Unix isn't just #include <linux.h>, i386, ILP32, ELF, ...!