tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: link-state change for virtual interfaces



Hi,

On 2024/09/26 1:54, Roy Marples wrote:
1) shmif_mediachange() should not test ifp->if_link_state, it should just call if_link_state_change()

2) shmif_mediastatus() does not set IFM_AVALID or IFM_ACTIVE in ifm_status

I've committed fix and requested to pullup to netbsd-10:
https://releng.netbsd.org/cgi-bin/req-10.cgi?show=924

Let me thank you again for careful review!!

This probably let to the addition of linkstate to `ifconfig -v` which wasn't really needed.
If it sets IFM_AVALID then the status line as shown anove will appear.

Yes, now "linkstate:" line became redundant for shmif(4). But
we hope not to remove this feature from ifconfig(8); It is still
useful for debugging, e.g., broken if/mii devices. Also, it gets
output only if `-v` option is specified.

Thanks,
rin


Home | Main Index | Thread Index | Old Index